Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move VMA, XVA and VBK to dissect.archive #8

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Move VMA, XVA and VBK to dissect.archive #8

merged 3 commits into from
Nov 7, 2024

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Nov 6, 2024

@Schamper Schamper requested a review from twiggler November 6, 2024 13:39
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 878 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (4fe8392) to head (b0a90df).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/archive/vbk.py 0.00% 457 Missing ⚠️
dissect/archive/vma.py 0.00% 186 Missing ⚠️
dissect/archive/tools/backup.py 0.00% 145 Missing ⚠️
dissect/archive/xva.py 0.00% 76 Missing ⚠️
dissect/archive/c_vbk.py 0.00% 5 Missing ⚠️
dissect/archive/c_vma.py 0.00% 5 Missing ⚠️
dissect/archive/exceptions.py 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##            main      #8    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          3       9     +6     
  Lines        311    1187   +876     
======================================
- Misses       311    1187   +876
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper mentioned this pull request Nov 6, 2024
Merged
@Schamper Schamper changed the title Move VMA and VBK to dissect.archive Move VMA, XVA and VBK to dissect.archive Nov 6, 2024
twiggler
twiggler requested changes Nov 6, 2024
View reviewed changes
Copy link

@twiggler twiggler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't project.scripts of pyproject.toml be adjusted?

@Schamper Schamper requested a review from twiggler November 6, 2024 15:46
@Schamper Schamper merged commit 5dfad11 into main Nov 7, 2024
20 checks passed
@Schamper Schamper deleted the add-vma-vbk branch November 7, 2024 13:07
@twiggler twiggler mentioned this pull request Nov 11, 2024
Merged
@twiggler twiggler mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiggler twiggler twiggler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schamper @twiggler